Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/ci-sage.yml: New #12

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mkoeppe
Copy link
Collaborator

@mkoeppe mkoeppe commented Mar 17, 2024

This adds integration testing with SageMath, on several Linux distributions with a wide range of versions of GNU make.

Preview of the workflow run: https://github.com/mkoeppe/gnumake-tokenpool/actions/workflows/ci-sage.yml

@mkoeppe mkoeppe marked this pull request as ready for review March 18, 2024 01:03
@milahu
Copy link
Owner

milahu commented Mar 18, 2024

no, 4x 1 hour is too much

to compare py/test/test.sh takes 20 seconds

@mkoeppe
Copy link
Collaborator Author

mkoeppe commented Mar 20, 2024

Sure, I'll reduce it

@milahu
Copy link
Owner

milahu commented Mar 20, 2024

please avoid integration tests
synthetic tests that run few seconds are enough

were just reading/writing some bytes between pipes
and the few edge cases can be simulated

@mkoeppe mkoeppe marked this pull request as draft March 30, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants